Conversation
…lity and maintainability. Updated footer in mailer layout to remove redundant reply instructions.
… check - Modified the test to ensure that Time objects are converted to Date before being stored in held_on_dates. - Updated the expectation to check against the current Time object for accuracy.
- Introduced a new LSA logo image (LSA_Logo.png) for use in email communications. - Updated ApplicationMailer to attach the LSA logo inline for emails. - Removed the previous attachment of LSA_Logo.svg from StudentMailer. - Modified mailer layout to display the LSA logo, prioritizing the PNG format over SVG.
- Updated VIP model to require an office number, ensuring all VIPs have this attribute. - Modified appointment creation and update processes to handle office numbers, defaulting from the associated VIP when not provided. - Enhanced request specs to validate office number presence during VIP creation and updates. - Updated views and forms to include office number fields, ensuring they are required and properly displayed. - Adjusted bulk upload service to handle office numbers, ensuring they are processed correctly from CSV files. - Refactored related tests to ensure comprehensive coverage of new office number functionality.
- Introduced office_number column to both VIPs and Appointments tables. - Updated schema to reflect the new version after migration. - Created migration files for adding office_number to the respective tables.
- Updated the rendering of the office number in the VIPs index view to use the `tag.span` helper for better HTML structure and maintainability.
- Introduced a new Stimulus controller (`vip_office_number_controller.js`) to synchronize the office number field with the selected VIP's office number. - Updated appointment edit and new views to utilize the new controller, enhancing user experience by auto-filling the office number based on the selected VIP. - Adjusted the appointment model to ensure the office number is set only on creation, preventing unintended overwrites during updates. - Removed inline JavaScript for handling office number updates, improving maintainability and adhering to the Stimulus framework.
- Introduced shared page instructions in the calendar, appointments, and questionnaires views to enhance user guidance. - Updated the `PageContent` model to include new paths for the added views, ensuring proper routing and content management.
Add-VIP-office
Bumps [httparty](https://github.com/jnunemaker/httparty) from 0.23.2 to 0.24.0. - [Release notes](https://github.com/jnunemaker/httparty/releases) - [Changelog](https://github.com/jnunemaker/httparty/blob/main/Changelog.md) - [Commits](jnunemaker/httparty@v0.23.2...v0.24.0) --- updated-dependencies: - dependency-name: httparty dependency-version: 0.24.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bump httparty from 0.23.2 to 0.24.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Related Issues
Type of Change
How Has This Been Tested?
Checklist