fix: add missing delay between clicks in MouseDClick()#167
Open
Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Open
fix: add missing delay between clicks in MouseDClick()#167Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Conversation
MouseDClick was firing two click events without any delay between MouseDown and MouseUp, which can cause the OS to interpret them as a single long press instead of a double-click. Now matches MouseClick behavior with staytime delay between down/up and 0.05s gap between the two clicks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
memory/ljqCtrl.py,MouseDClick()fires two rapid click events without any delay betweenMouseDown()andMouseUp():Compare with
MouseClick()which hastime.sleep(staytime)between down/up. Without this delay, the OS may interpret the two rapid clicks as a single long press rather than a double-click, makingMouseDClick()unreliable.Fix
Add
time.sleep(staytime)between eachMouseDown()/MouseUp()pair, andtime.sleep(0.05)between the two clicks, matchingMouseClick()behavior:Impact
MouseClick()implementation