fix: prevent uncaught JSONDecodeError in tryparse() fallback#169
Open
Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Open
fix: prevent uncaught JSONDecodeError in tryparse() fallback#169Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Dabao21 wants to merge 1 commit intolsdefine:mainfrom
Conversation
The last json.loads() in tryparse() could still throw JSONDecodeError when all recovery attempts fail, crashing the tool call parser. Now returns {_raw: json_str} on final failure, consistent with _try_parse_tool_args() behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
llmcore.py, thetryparse()function attempts multiple strategies to recover malformed JSON from LLM output. However, the finaljson.loads()call after trimming to the last}is not wrapped in a try/except block:When all recovery attempts fail, this raises an uncaught
JSONDecodeErrorthat crashes the tool call parser.Fix
Wrap the final
json.loads()in a try/except, returning{"_raw": json_str}on failure. This is consistent with the behavior of_try_parse_tool_args()which also returns a fallback dict when parsing fails.Impact
{"_raw": ...}fallback allows downstream code to still access the raw text for debugging