Open
Conversation
Go runtime is installed in /go which is word writable so there is no need for a dedicated user. This removes the need to usermod at runtime which was very time consuming. Not having to manipulate the user at runtime allows to remove the entrypoint script entirely. With this setup the language server is up and running in milliseconds rather than seconds. I based this image on official golang alpine image to avoid as much duplication as possible
Author
|
This could also solve lspcontainers/lspcontainers.nvim#68 (not sure though) |
Contributor
|
I will test it later today or in the next few days, thanks! |
Contributor
|
Okay I can confirm, this solves the |
Contributor
|
I just ran into a problem with this and I am not sure whether this is again podman related or not. While using your image with the |
Contributor
|
I believe I may have improved this in a separate PR if you don't mind testing this LSP and seeing if it's running faster. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gopls image startup is really slow. This is mainly due to the usermod and chmod performed by the entrypoint script.
I tried to implement another dockerfile which uses the official golang images. They are installing go in a world writable directory, so there is no need for a dedicated user any more (hence no usermod and the image spins in milliseconds).
I had to define a GOCACHE dir, but apart from that the image it quite simple and seems to be working fine.
I am testing it on my env with this conf