DM-35115: Add bulge_flux_fraction column to source injection schema#691
Open
jmeyers314 wants to merge 4 commits intomainfrom
Open
DM-35115: Add bulge_flux_fraction column to source injection schema#691jmeyers314 wants to merge 4 commits intomainfrom
jmeyers314 wants to merge 4 commits intomainfrom
Conversation
jmeyers314
force-pushed
the
tickets/DM-35115
branch
from
0daad62 to
6824dca
Compare
timj
reviewed
Jun 13, 2022
Member
timj
left a comment
timj
left a comment
There was a problem hiding this comment.
Quick comment about log message conventions: (1) f-strings should not be used in debug log messages (I didn't comment on every place) (2) some of your logs are missing the %s.
| posi = galsim.PositionI(pt.x//1, pt.y//1) | ||
| if logger: | ||
| logger.debug(f"Adding fake source at {pt}") | ||
| logger.debug(f"Adding fake source {gsObj} at {pt}") |
Member
There was a problem hiding this comment.
I know there is some debate over f-strings in warning and info level messages but for debug we should be using deferred stringifcation so that the final string is only formed if the debug message is going to be issued.
| 'select' | ||
| ) | ||
| if replace_dict: | ||
| self.log.debug("Replacing columns:", replace_dict) |
Member
There was a problem hiding this comment.
This should be:
self.log.debug("Replacing columns: %s", replace_dict)| copy=False | ||
| ) | ||
| if replace_dict: | ||
| self.log.debug("Replacing columns:", replace_dict) |
Member
There was a problem hiding this comment.
Same as above. The log message should include the %s.
jmeyers314
force-pushed
the
tickets/DM-35115
branch
from
10c1631 to
de7439f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.