Init CI workflow for pull requests#53
Merged
Nicell merged 2 commits intoMar 19, 2026
Merged
Conversation
Nicell
reviewed
Mar 17, 2026
Collaborator
Nicell
left a comment
Nicell
left a comment
There was a problem hiding this comment.
thanks for working on this! two small comments
Comment on lines
+62
to
+64
| - name: Test | ||
| shell: bash | ||
| run: npm test |
Collaborator
There was a problem hiding this comment.
this doesn't exist yet, should be added with the first tests
Contributor
Author
There was a problem hiding this comment.
Suggested a workflow for this in PR #52.
| wasm/luau | ||
| public/wasm/luau.wasm | ||
| src/lib/luau/luau-module.js | ||
| key: build-${{ runner.os }}-${{ hashFiles('wasm/src/**', 'wasm/CMakeLists.txt', 'wasm/build.sh') }}-luau-${{ github.run_id }} |
Collaborator
There was a problem hiding this comment.
now that we're building on PRs, we should probably make this key a bit better. let's drop the run_id from the key and add the luau commit sha to this, that's more correct. can output it right after pulling latest in the luau repo.
Contributor
Author
There was a problem hiding this comment.
Good point! I would also propose linking to the release commit rather than the head commit, following the approach used in lute(line).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used the workflow in
luteas an example to build this one..github/workflows/deploy.ymlto.github/actions/build/action.yml..github/workflows/ci.yml, which will trigger on new pull requests tomain. New pushes to the samePRshould cancel in-progressCIruns.type checkingfor each workflow.Resolves #18.