Uniform spectrum#140
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new UniformSpectrum implementation to generate X-ray energies uniformly between two bounds, and updates the hexagonal-grid ADC routing helpers to support NumPy-array (vectorized) inputs.
Changes:
- Added
UniformSpectrum(rvs()+ plotting support) and exposed it viahexsample.source. - Added a unit test validating
UniformSpectrum.rvs()output range and basic plotting. - Updated ADC routing sequences/functions in
hexagon.pyto operate with NumPy arrays (enabling vectorized routing).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tests/test_source.py | Adds UniformSpectrum import and a new test for sampling bounds/plotting. |
| src/hexsample/source.py | Introduces the UniformSpectrum spectrum type and exports it. |
| src/hexsample/hexagon.py | Switches ADC lookup sequences to NumPy arrays and updates ADC-channel functions’ typing/docs for vectorized use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
127
to
130
| _N_ADC_CHANNELS = 7 | ||
| _ADC_SEQUENCE_EVEN = (0, 2, 5, 0, 3, 5, 1, 3, 6, 1, 4, 6, 2, 4) | ||
| _ADC_SEQUENCE_ODD = (0, 3, 5, 1, 3, 6, 1, 4, 6, 2, 4, 0, 2, 5) | ||
| _ADC_SEQUENCE_EVEN = np.array([0, 2, 5, 0, 3, 5, 1, 3, 6, 1, 4, 6, 2, 4]) | ||
| _ADC_SEQUENCE_ODD = np.array([0, 3, 5, 1, 3, 6, 1, 4, 6, 2, 4, 0, 2, 5]) | ||
| _ADC_SEQUENCE_LENGTH = len(_ADC_SEQUENCE_EVEN) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.