Prefix one-time trigger with job name#133
Merged
tmccombs merged 1 commit intolucidsoftware:masterfrom Feb 26, 2026
Merged
Conversation
aegbert5
force-pushed
the
prefix-one-time-triggers-with-job-name
branch
2 times, most recently
from
2273242 to
b250b16
Compare
tmccombs
requested changes
Feb 25, 2026
worker/src/main/scala/com/lucidchart/piezo/JobHistoryModel.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/JobHistoryModel.scala
Outdated
Show resolved
Hide resolved
aegbert5
force-pushed
the
prefix-one-time-triggers-with-job-name
branch
3 times, most recently
from
0c82217 to
a29fa98
Compare
aegbert5
force-pushed
the
prefix-one-time-triggers-with-job-name
branch
2 times, most recently
from
81fffef to
2765318
Compare
aegbert5
force-pushed
the
prefix-one-time-triggers-with-job-name
branch
from
2765318 to
53ade75
Compare
tmccombs
reviewed
Feb 26, 2026
| TriggerKey(fireInstanceId, oneTimeJobTriggerGroup) | ||
|
|
||
| // Makes the job id unique per job, instead of globally unique | ||
| final def getFireInstanceIdFromOneTimeJobId(group: String, name: String, oneTimeJobId: Long): String = |
Contributor
Author
There was a problem hiding this comment.
No, there are a few places in tests where we call this method
tmccombs
approved these changes
Feb 26, 2026
tmccombs
added a commit
that referenced
this pull request
Feb 26, 2026
Use a newtype so that ensure that we are passing around the right thing. Also make some methods more private. This is built on top of #133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-time-trigger ids are currently defined with the
id: Longsent to piezo-admin. Instead of making these ids globally unique, we should make them unique per job name + job group