Conversation
jadenPete
force-pushed
the
migrate-to-bzlmod
branch
from
53a6352 to
30da3a3
Compare
|
Squashed. |
jadenPete
force-pushed
the
migrate-to-bzlmod
branch
from
895ff9d to
ab85ac0
Compare
|
Squashed. |
jadenPete
force-pushed
the
migrate-to-bzlmod
branch
from
c726e57 to
bf25756
Compare
|
Squashed. |
|
|
||
| bazel build @rules_scala_annex//rules/scalafmt | ||
| scalafmtbin="bazel-bin/external/rules_scala_annex/rules/scalafmt/scalafmt-bin" | ||
| scalafmtbin="$(mktemp)" |
There was a problem hiding this comment.
I don't think this will work if the default temp directory (/tmp on linux) is mounted as noexec, which is fairly common.
Some possible workarounds:
- If the script is a shell script, always invoke with
bashinstead of calling it directly - Write to a well-known path in the current directory
- Use
--tmpdirtomktempto have it create the file in a directory that is more likely to allow execution, like the current directory
There was a problem hiding this comment.
Good point; I hadn't thought of that. I like the first alternative you listed the most, since it doesn't leave the possibility of a lingering script in the working directory. I'll go with that.
| strategy: | ||
| matrix: | ||
| os: [ubuntu-20.04] | ||
| bazel_version: [bazelbuild/5.4.1, bazelbuild/6.4.0] |
There was a problem hiding this comment.
Do we want to use the bazel-contrib/setup-bazel@0.8.5 step like we do in the other rule sets?
There was a problem hiding this comment.
Hmm, I'm surprised the builds pass without it. I'll add it.
.github/workflows/ci.yml
Outdated
| matrix: | ||
| os: [ubuntu-20.04] | ||
| bazel_version: [bazelbuild/5.4.1, bazelbuild/6.4.0] | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
While you're here could we bump this to 24.04? 20.04 is going away soon on GitHub actions.
MODULE.bazel
Outdated
| "org.scala-lang:scala-compiler:{}".format(scala_version), | ||
| "org.scala-lang:scala-library:{}".format(scala_version), | ||
| "org.scala-lang:scala-reflect:{}".format(scala_version), | ||
| "org.scala-sbt:compiler-bridge_2.13:1.9.5", |
There was a problem hiding this comment.
While we're here I think updating the compiler bridge to the latest Zinc version we're using in the other rule sets makes sense. 1.10.4
There was a problem hiding this comment.
Good idea! I just upgraded it.
jadenPete
force-pushed
the
migrate-to-bzlmod
branch
from
1bf8352 to
97cd950
Compare
|
Squashed. |
4 participants
No description provided.