Upgrade to Bazel 8 by jadenPete · Pull Request #30 · lucidsoftware/rules_hocon

jadenPete · 2025-01-23T16:04:17Z

No description provided.

jadenPete · 2025-01-23T16:04:47Z

MODULE.bazel

 bazel_dep(name = "buildifier_prebuilt", version = "8.0.1", dev_dependency = True)

-rules_scala_annex_version = "lucid_2024-12-06"
+rules_scala_annex_version = "upgrade-to-bazel-8"


Wait until upgrade-to-bazel-8 is merged and change this to a release tag.

jadenPete · 2025-01-23T16:05:10Z

Wait until migrate-to-bzlmod is merged.

jadenPete · 2025-01-23T18:16:01Z

Rebased off of migrate-to-bzlmod.

tmccombs · 2025-01-23T18:35:13Z

tests/optional_includes/BUILD.bazel

        "2.conf",
        "3.conf",
    ],
-    deps = glob(["config/2.conf"]) + glob(["config/3.conf"]),


Why are we removing config/2.conf from here?

IIRC the purpose of using globs here was to show how to use an optional dependency, where the file may or may not exist. This is something that we use in our codebase in order to allow developers to override configuration with a file that isn't checked into git.

I was receiving errors that they didn't exist, but re-add this line and add allow_empty = True arguments.

tmccombs · 2025-01-23T18:38:56Z

The build is failing:

ERROR: /home/runner/.cache/bazel/_bazel_runner/810d6126909a697c02d0c7230fed4929/external/rules_jvm_external++maven+annex/BUILD:4319:8: Executing genrule @@rules_jvm_external++maven+annex//:org_scala_lang_scala_reflect_2_13_15_extension failed: (Exit 1): bash failed: error executing Genrule command (from target @@rules_jvm_external++maven+annex//:org_scala_lang_scala_reflect_2_13_15_extension) 
  (cd /home/runner/.cache/bazel/_bazel_runner/810d6126909a697c02d0c7230fed4929/sandbox/linux-sandbox/2/execroot/_main && \
  exec env - \
    PATH=/bin:/usr/bin:/usr/local/bin \
  /bin/bash -c 'source external/bazel_tools/tools/genrule/genrule-setup.sh; cp external/rules_jvm_external++maven+org_scala_lang_scala_reflect_2_13_15/file/v1/org/scala-lang/scala-reflect/2.13.15/scala-reflect-2.13.15.jar bazel-out/k8-fastbuild/bin/external/rules_jvm_external++maven+annex/org/scala-lang/scala-reflect/2.13.15/scala-reflect-2.13.15.jar')
# Configuration: d336d1c852743625f01c41e329ea436930007b1c0ad80e7736d9034bd6c78a33
# Execution platform: @@platforms//host:host

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/main/tools/linux-sandbox-pid1.cc:516: "execvp(/bin/bash, 0x1891b7f0)": No such file or directory
ERROR: /home/runner/.cache/bazel/_bazel_runner/810d6126909a697c02d0c7230fed4929/external/rules_jvm_external++maven+annex/BUILD:3825:8: Executing genrule @@rules_jvm_external++maven+annex//:org_jline_jline_3_26_3_extension failed: (Exit 1): bash failed: error executing Genrule command (from target @@rules_jvm_external++maven+annex//:org_jline_jline_3_26_3_extension) 
  (cd /home/runner/.cache/bazel/_bazel_runner/810d6126909a697c02d0c7230fed4929/sandbox/linux-sandbox/1/execroot/_main && \
  exec env - \
    PATH=/bin:/usr/bin:/usr/local/bin \
  /bin/bash -c 'source external/bazel_tools/tools/genrule/genrule-setup.sh; cp external/rules_jvm_external++maven+org_jline_jline_3_26_3/file/v1/org/jline/jline/3.26.3/jline-3.26.3.jar bazel-out/k8-fastbuild/bin/external/rules_jvm_external++maven+annex/org/jline/jline/3.26.3/jline-3.26.3.jar')
# Configuration: d336d1c852743625f01c41e329ea436930007b1c0ad80e7736d9034bd6c78a33
# Execution platform: @@platforms//host:host

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/main/tools/linux-sandbox-pid1.cc:516: "execvp(/bin/bash, 0x33f297f0)": No such file or directory
Target @@rules_scala_annex+//rules/scalafmt:scalafmt failed to build

tmccombs

failing build

jjudd · 2025-02-19T22:18:56Z

.bazelversion

@@ -1 +1 @@
-7.4.1
+8.0.1


8.1.0 is out now, so let's use that instead.

Done! Now, we're using our custom version of Bazel, which is based on v8.1.1.

jadenPete · 2025-02-28T00:37:55Z

Rebased off of master.

jadenPete · 2025-02-28T00:47:11Z

Squashed.

jadenPete · 2025-02-28T00:48:09Z

The build is failing:

ERROR: /home/runner/.cache/bazel/_bazel_runner/810d6126909a697c02d0c7230fed4929/external/rules_jvm_external++maven+annex/BUILD:4319:8: Executing genrule @@rules_jvm_external++maven+annex//:org_scala_lang_scala_reflect_2_13_15_extension failed: (Exit 1): bash failed: error executing Genrule command (from target @@rules_jvm_external++maven+annex//:org_scala_lang_scala_reflect_2_13_15_extension) 
  (cd /home/runner/.cache/bazel/_bazel_runner/810d6126909a697c02d0c7230fed4929/sandbox/linux-sandbox/2/execroot/_main && \
  exec env - \
    PATH=/bin:/usr/bin:/usr/local/bin \
  /bin/bash -c 'source external/bazel_tools/tools/genrule/genrule-setup.sh; cp external/rules_jvm_external++maven+org_scala_lang_scala_reflect_2_13_15/file/v1/org/scala-lang/scala-reflect/2.13.15/scala-reflect-2.13.15.jar bazel-out/k8-fastbuild/bin/external/rules_jvm_external++maven+annex/org/scala-lang/scala-reflect/2.13.15/scala-reflect-2.13.15.jar')
# Configuration: d336d1c852743625f01c41e329ea436930007b1c0ad80e7736d9034bd6c78a33
# Execution platform: @@platforms//host:host

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/main/tools/linux-sandbox-pid1.cc:516: "execvp(/bin/bash, 0x1891b7f0)": No such file or directory
ERROR: /home/runner/.cache/bazel/_bazel_runner/810d6126909a697c02d0c7230fed4929/external/rules_jvm_external++maven+annex/BUILD:3825:8: Executing genrule @@rules_jvm_external++maven+annex//:org_jline_jline_3_26_3_extension failed: (Exit 1): bash failed: error executing Genrule command (from target @@rules_jvm_external++maven+annex//:org_jline_jline_3_26_3_extension) 
  (cd /home/runner/.cache/bazel/_bazel_runner/810d6126909a697c02d0c7230fed4929/sandbox/linux-sandbox/1/execroot/_main && \
  exec env - \
    PATH=/bin:/usr/bin:/usr/local/bin \
  /bin/bash -c 'source external/bazel_tools/tools/genrule/genrule-setup.sh; cp external/rules_jvm_external++maven+org_jline_jline_3_26_3/file/v1/org/jline/jline/3.26.3/jline-3.26.3.jar bazel-out/k8-fastbuild/bin/external/rules_jvm_external++maven+annex/org/jline/jline/3.26.3/jline-3.26.3.jar')
# Configuration: d336d1c852743625f01c41e329ea436930007b1c0ad80e7736d9034bd6c78a33
# Execution platform: @@platforms//host:host

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/main/tools/linux-sandbox-pid1.cc:516: "execvp(/bin/bash, 0x33f297f0)": No such file or directory
Target @@rules_scala_annex+//rules/scalafmt:scalafmt failed to build

I think this should be fixed with my latest changes, but we'll see. I know this is a bug with the sandbox, but I'm unsure what exactly causes it. @jjudd likely knows more than me on this one.

…ction_env The former is deprecated and has been replaced with the latter.

jadenPete · 2025-02-28T00:54:00Z

Squashed.

jadenPete requested a review from jjudd January 23, 2025 16:04

jadenPete commented Jan 23, 2025

View reviewed changes

jadenPete force-pushed the migrate-to-bzlmod branch from c726e57 to bf25756 Compare January 23, 2025 18:14

jadenPete force-pushed the upgrade-to-bazel-8 branch from 2c28541 to eb0fa14 Compare January 23, 2025 18:15

tmccombs reviewed Jan 23, 2025

View reviewed changes

tmccombs requested changes Jan 23, 2025

View reviewed changes

jjudd reviewed Feb 19, 2025

View reviewed changes

jadenPete force-pushed the migrate-to-bzlmod branch from 1bf8352 to 97cd950 Compare February 28, 2025 00:12

jadenPete force-pushed the upgrade-to-bazel-8 branch from eb0fa14 to 47b0204 Compare February 28, 2025 00:37

jadenPete changed the base branch from migrate-to-bzlmod to master February 28, 2025 00:38

jadenPete force-pushed the upgrade-to-bazel-8 branch from d27ddaa to 033c323 Compare February 28, 2025 00:47

jadenPete-lucid added 4 commits February 27, 2025 19:53

Upgrade to Bazel 8

5b98607

Sort .bazelrc

735bb1a

Replace --experimental_strict_action_env with --incompatible_strict_a…

4991112

…ction_env The former is deprecated and has been replaced with the latter.

Use the same .bazelrc as lucidsoftware/rules_scala

8ce9de8

jadenPete force-pushed the upgrade-to-bazel-8 branch from 2d2c46b to 8ce9de8 Compare February 28, 2025 00:53

jjudd approved these changes Feb 28, 2025

View reviewed changes

jadenPete merged commit 72ff185 into master Feb 28, 2025
1 check passed

		@@ -1 +1 @@
		7.4.1
		8.0.1

Conversation

jadenPete commented Jan 23, 2025

Uh oh!

jadenPete Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jadenPete commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jadenPete commented Jan 23, 2025

Uh oh!

tmccombs Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

tmccombs Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

jadenPete Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

tmccombs commented Jan 23, 2025

Uh oh!

tmccombs left a comment

Choose a reason for hiding this comment

Uh oh!

jjudd Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

jadenPete Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

jadenPete commented Feb 28, 2025

Uh oh!

jadenPete commented Feb 28, 2025

Uh oh!

jadenPete commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jadenPete commented Feb 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jadenPete Jan 23, 2025 •

edited

Loading

jadenPete commented Jan 23, 2025 •

edited

Loading

jadenPete commented Feb 28, 2025 •

edited

Loading