[codex] Switch npm release to trusted publishing#10
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
id-token: writeso npm can use GitHub Actions OIDC trusted publishing.contents: writeandpull-requests: writefor Changesets version PRs/commits.actions/setup-nodewith the npm registry URL.changeset publish, then removes the long-livedNPM_TOKENfrom the publish environment.Why
The publish run failed with npm
E404 Not Foundwhile trying to publishpatchworks@0.1.3, which is the error npm returns when the registry request is not authorized for that package. Moving to trusted publishing avoids a stale or incorrectly scoped npm token and lets npm authorize the exact GitHub Actions workflow through OIDC.Required npm setup
Configure the
patchworkspackage on npmjs.com with a Trusted Publisher:ludicroushqpatchworksrelease.yamlnpm publishValidation
pnpm run ci:test:prettygit diff --check