Skip to content

feat: add other primitive/base type support#4

Merged
luizaes merged 6 commits into
luizaes:mainfrom
ntark:main
Dec 1, 2025
Merged

feat: add other primitive/base type support#4
luizaes merged 6 commits into
luizaes:mainfrom
ntark:main

Conversation

@ntark

@ntark ntark commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Really need long/decimal support for my use case and just added all I could think of.
@luizaes Could you look take a look please?

Readme file will also need to be edited if this PR is merged.

@luizaes luizaes self-requested a review December 1, 2025 02:30

@luizaes luizaes left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ntark, thank you for your contribution! ✨

I've changed one thing in your code: instead of manually mapping the base types to their defaults in the MaskDefaults dict, we know just use their respective default(T) value. I think it makes more sense, and it correlates to a future change I want to do where all other types also map to their default. The bahavior should be identical, with the exception of char which will now map to \0 instead of 0 (see https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/default-values).

I've also updated the documentation accordingly like you mentioned. I'll merge this change and should upload a new version to NuGet shortly after. Thanks again!

@luizaes luizaes merged commit 8d2f29c into luizaes:main Dec 1, 2025
1 of 2 checks passed
@luizaes luizaes added the enhancement New feature or request label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants