Feature/Sidebar use theme background color#24
Open
FraDeliro wants to merge 3 commits into
Open
Conversation
… color for sidebar background
Owner
|
Thanks for this! A few thought on it though before merging it in:
|
… according to sidebar background
Author
|
@lukakerr Thank you for your reply ;) I have updated my PR, at the moment as you can see in the new screenshots, when one item in the sidebar is selected the text is always light but, if not, the textColor changes depending on sidebar background. For the bottom panel instead, the custom view that contains the NSVisualEffectView it's getting now the same sidebar color. I was not sure if you wanted to change the visual effect view color but if there is anything to be improved or modified, let me know :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a feature to add the option to use theme color for sidebar background color.
Related to #13
Minimum required changes, including:
Image after