Skip to content

Remove footpads disabling LEDs on startup#74

Open
Eli-Parker wants to merge 1 commit intolukash:mainfrom
Eli-Parker:fix-led-disable
Open

Remove footpads disabling LEDs on startup#74
Eli-Parker wants to merge 1 commit intolukash:mainfrom
Eli-Parker:fix-led-disable

Conversation

@Eli-Parker
Copy link

Remove the disabling of LEDs if both sensors are pressed during startup. Settings.xml LED Mode description is updated to reflect the change

Copy link
Owner

@lukash lukash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, code LGTM.

I'm using a git commit trailer mechanism for tracking changelog records, could you add such changelog record to the commit message? It'll also automatically attribute the change to the commit author name in the changelog. Just add a "Feature: ..." trailer, it's described in CONTRIBUTING.md, you can also check past commits for examples and you can run ./changelog.py to see what it outputs. (note I use a very crude mechanism for multiline formatted content of the git trailer, not proud of it but it does the job...)

My idea of what it should look like (feel free to improve it):

Feature: Don't disable LEDs if both sensors are pressed at startup
 >
 This mechanism was in place for the potential case of the LED
 initialization locking up the board in a way that would prevent the
 user from connecting and fixing the problem. This has proven unneeded,
 so the feature is being removed.

Remove the disabling of LEDs if both sensors are pressed during startup. Settings.xml LED Mode description is updated to reflect the change

Feature: Don't disable LEDs if both sensors are pressed at startup
 >
 This mechanism was in place for the potential case of LED
 initialization locking up the board in a way that would prevent the
 user from connecting to fix the problem. This has proven unneeded,
 so the feature is being removed.
@Eli-Parker
Copy link
Author

I've amended with the feature tag added and the updated XML from VESC Tool. All looks good in changelog.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants