Skip to content

Reheating with lnR_rad#69

Open
lukashergt wants to merge 18 commits into
masterfrom
reheating_with_lnR_rad
Open

Reheating with lnR_rad#69
lukashergt wants to merge 18 commits into
masterfrom
reheating_with_lnR_rad

Conversation

@lukashergt
Copy link
Copy Markdown
Owner

@lukashergt lukashergt commented Jul 30, 2025

I was encouraged to investigate lnR_rad as an alternative reheating parameter. From a prior weight perspective, I am fairly sure that this will be equivalent to N_star.

Checklist:

  • I have performed a self-review of my own code.
  • My code is PEP8 compliant (flake8 --max-line-length 99 primpy tests).
  • My code contains compliant docstrings (pydocstyle --convention=numpy primpy).
  • New and existing unit tests pass locally with my changes (python -m pytest).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/__version__.py.

@lukashergt lukashergt self-assigned this Jul 30, 2025
@lukashergt lukashergt added the enhancement New feature or request label Jul 30, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.06%. Comparing base (723f7c7) to head (b89e04e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   99.05%   99.06%   +0.01%     
==========================================
  Files          18       19       +1     
  Lines        2325     2356      +31     
==========================================
+ Hits         2303     2334      +31     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukashergt lukashergt requested a review from Copilot August 4, 2025 11:26

This comment was marked as outdated.

@lukashergt lukashergt requested a review from Copilot August 6, 2025 15:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces lnR_rad as an alternative reheating parameter that is agnostic to the details of reheating. The implementation adds support for this parameter in the calibration methods and includes comprehensive test coverage for various parameter combinations.

  • Adds lnR_rad parameter support to calibration methods as a reheating-agnostic alternative
  • Creates new helper functions for instant reheating validation
  • Extends test coverage to validate parameter consistency across different calibration approaches

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
primpy/reheating.py New module containing instant reheating validation logic
primpy/inflation.py Integrates lnR_rad parameter into calibration methods with validation
tests/test_inflation.py Comprehensive test coverage for new parameter combinations and validation scenarios
cobaya_wrapper/slowroll_pps.py Minor adjustments to phi_i calculation and comoving Hubble horizon output
primpy/version.py Version bump to 2.17.0
README.rst Version update in documentation

Comment thread primpy/reheating.py
Comment thread primpy/inflation.py
Comment thread tests/test_inflation.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants