Reheating with lnR_rad#69
Open
lukashergt wants to merge 18 commits into
Open
Conversation
…rapper to the main computation; DeltaN_reh<0 and w_reh<-1/3 are always unacceptable by definition
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 99.05% 99.06% +0.01%
==========================================
Files 18 19 +1
Lines 2325 2356 +31
==========================================
+ Hits 2303 2334 +31
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…omplex with the addition of `lnR_rad`; create new dedicated function in new `reheating.py` module
…rect setting of nans to improve test coverage
…e same parameters get set (to nans if necessary); add missing `rho_reh_mp4` parameter for some scenarios
There was a problem hiding this comment.
Pull Request Overview
This PR introduces lnR_rad as an alternative reheating parameter that is agnostic to the details of reheating. The implementation adds support for this parameter in the calibration methods and includes comprehensive test coverage for various parameter combinations.
- Adds
lnR_radparameter support to calibration methods as a reheating-agnostic alternative - Creates new helper functions for instant reheating validation
- Extends test coverage to validate parameter consistency across different calibration approaches
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| primpy/reheating.py | New module containing instant reheating validation logic |
| primpy/inflation.py | Integrates lnR_rad parameter into calibration methods with validation |
| tests/test_inflation.py | Comprehensive test coverage for new parameter combinations and validation scenarios |
| cobaya_wrapper/slowroll_pps.py | Minor adjustments to phi_i calculation and comoving Hubble horizon output |
| primpy/version.py | Version bump to 2.17.0 |
| README.rst | Version update in documentation |
… better estimation of the difficult `n_runrun`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was encouraged to investigate
lnR_radas an alternative reheating parameter. From a prior weight perspective, I am fairly sure that this will be equivalent toN_star.Checklist:
flake8 --max-line-length 99 primpy tests).pydocstyle --convention=numpy primpy).python -m pytest).README.rstandanesthetic/__version__.py.