Skip to content

Improve Date comparison - #245

Draft
ArtskydJ wants to merge 1 commit into
lukeed:masterfrom
ArtskydJ:fix-92
Draft

Improve Date comparison#245
ArtskydJ wants to merge 1 commit into
lukeed:masterfrom
ArtskydJ:fix-92

Conversation

@ArtskydJ

@ArtskydJ ArtskydJ commented Jun 9, 2024

Copy link
Copy Markdown

Fixes #92.

Before:

    ++"2021-06-04T11:40:40.529Z"    (Expected)
    --                        {}    (Actual)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^

After:

    ++2021-06-04T11:40:40.529Z    (Expected)
    --2024-06-08T23:10:10.314Z    (Actual)
         ^     ^ ^^ ^  ^  ^^^

@ArtskydJ

ArtskydJ commented Jun 9, 2024

Copy link
Copy Markdown
Author

I realized this isn't actually working correctly for Dates inside objects.

@ArtskydJ
ArtskydJ marked this pull request as draft June 9, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Date comparison isn't very useful

1 participant

@ArtskydJ