fix: prevent crash when comparing Symbol to other types#259
Open
Mubashir78 wants to merge 1 commit into
Open
Conversation
The direct() function in the diff module calls String() on its inputs to compute their display lengths. String(Symbol()) throws a TypeError, causing an uncaught exception when comparing Symbol values to other types via assert.is() or assert.equal(). Extract a stringifyValue() helper that handles Symbol gracefully by using its description, and avoid mutating the original input/expect parameters to prevent similar issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
direct()function in the diff module callsString()on its inputs to compute their display lengths.String(Symbol())throws aTypeError, causing an uncaught exception when comparing Symbol values to other types viaassert.is()orassert.equal().Extract a
stringifyValue()helper that handles Symbol gracefully by using its description string, and avoid mutating the originalinput/expectparameters for the string representation.Fixes #251
Test plan
direct(Symbol("foo"), 42)now returns a proper diff string instead of throwing