refactor the two existing switch statements into polymorphic dispatch#2
Open
mbaranowski wants to merge 1 commit intoluketomlinson:masterfrom
Open
refactor the two existing switch statements into polymorphic dispatch#2mbaranowski wants to merge 1 commit intoluketomlinson:masterfrom
mbaranowski wants to merge 1 commit intoluketomlinson:masterfrom
Conversation
switch statement in condigureCell is replaced with AnyCellConfigurable.configure which force-casts and calls the type-specific CellConfigurable.configure we can assume all cells are of type AnyCellConfigurable because we register only using the cellTypes array, and that only allows AnyCellConfigurable.Type. the switch statement in cellType(for:) is replaced by the fact that CellViewModelType has an associatedtype of the cell type is can configure.
|
mbaranowski:refactorSwitches |
ANDREWPUL
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switch statement in condigureCell is replaced with AnyCellConfigurable.configure which force-casts and calls the type-specific CellConfigurable.configure
we can assume all cells are of type AnyCellConfigurable because we register only using the cellTypes array, and that only allows AnyCellConfigurable.Type.
the switch statement in cellType(for:) is replaced by the fact that CellViewModelType has an associatedtype of the cell type is can configure.