Enforce none_bump_behavior: disallow during changeset creation#114
Merged
Conversation
When none_bump_behavior is set to disallow, the add command now rejects none bumps at creation time rather than deferring the error to release or verify. Validation in collect_releases() catches both interactive and non-interactive paths, while the interactive menu hides the none option.
lukidoescode
changed the title
none_bump_behavior: disallow during changeset creation
Cover both interactive and non-interactive paths that were missing test coverage after the none_bump_behavior enforcement was added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
none_bump_behavioris set todisallow, the add command now rejectsnonebumps at creation time rather than deferring the error toreleaseorverify. Validation incollect_releases()catches both interactive and non-interactive paths, while the interactive menu hides the none option.