Skip to content

Fix multi-line env var values being truncated on Windows when injecting vcpkg environment#159

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fix-multi-line-env-vars-handling
Draft

Fix multi-line env var values being truncated on Windows when injecting vcpkg environment#159
Copilot wants to merge 2 commits intomainfrom
copilot/fix-multi-line-env-vars-handling

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 25, 2026

  • Investigate the issue: X_VCPKG_RECURSIVE_DATA multi-line env var handling in parseEnvVars
  • Core fix: compact multi-line values by joining continuation lines without newlines, producing valid single-line JSON that is safe for Windows environment variables
  • Additional robustness: validate env var key names with regex to handle JSON continuation lines containing =
  • Additional robustness: use \r?\n split for more explicit CRLF handling
  • Unit tests in parseEnvVars.test.ts documenting expected multi-line behavior
  • Run parallel validation (CodeQL clean, review comments addressed)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Fix handling of multi-line env vars in vcpkg Fix multi-line env var values being truncated on Windows when injecting vcpkg environment Mar 25, 2026
Copilot AI requested a review from lukka March 25, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vcpkg env multi-line env vars handled incorrectly?

2 participants