-
Notifications
You must be signed in to change notification settings - Fork 0
Hoist tokio spawn #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
JustinKovacich
wants to merge
14
commits into
feature/tokio_transport_and_socket_manager
from
feature/hoist_tokio_spawn
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
94cb236
Apply hoists: run_future doesnt call tokio::spawn, client::new/with_l…
JustinKovacich 07f7abe
Add testing, add sensible panics, updated docs
JustinKovacich 84ee4e8
phase 6: respond to PR #80 feedback (typed Shutdown + test/doc fixes)
JustinKovacich 7a8d2d4
lints: address must_use + README wording (Copilot round-2)
JustinKovacich a1a01ed
chore(clippy): address new warnings in hoist_tokio PR
JustinKovacich ffffa1a
PR #80 round: apply reviewer suggestions
JustinKovacich 452e47b
examples: bind spawn handle in client_server to avoid let_underscore_…
JustinKovacich 6646cf3
server: add #[must_use] to announcement_loop
JustinKovacich 118c8ce
client: distinguish pending_responses saturation from shutdown
JustinKovacich 8964f75
docs(error): add "pending_responses" to Capacity tag list
JustinKovacich 92606c1
fix: capture tokio::spawn JoinHandle to avoid unused_must_use warnings
JustinKovacich d92c5a3
fix: store and observe JoinHandles in production/example code
JustinKovacich 861c5d3
fix: use Tokio-specific wording and unique test service IDs
JustinKovacich 82df573
docs(server): fix Result signatures and executor wording in README AP…
JustinKovacich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.