Translate product-variants widget labels#2555
Open
yazdanghalavand wants to merge 1 commit into
Open
Conversation
The "Add shared option" and "Save variants" actions and the "No Product Options Configured" empty state rendered in English regardless of locale: the two actions had no ->label() so Filament humanised their names, and the empty-state heading was hardcoded in the Blade view. Apply the existing add-shared-option translation key to its action, add a save-variants label key and apply it, and route the hardcoded heading through options-list.empty.heading (the sibling empty states already use translation keys). Fixes lunarphp#2554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2554.
Three strings on the product Variants screen rendered in English regardless of locale:
->label(), so Filament humanised the action names.Changes
ProductOptionsWidget— apply the existingadd-shared-option.labelkey to theaddSharedOptionaction, and a newsave-variants.labelkey to thesaveVariantsaction.lang/en/productoption.php— add thesave-variants.labelkey (Save Variants). Other locales fall back to English until translated.product-options.blade.php— route the hardcoded empty-state heading throughoptions-list.empty.heading.No behaviour change beyond localisation; verified in a Turkish-locale panel that all three now translate.