ci: test latest Go only and bump go.mod to 1.26.0#191
Conversation
📝 WalkthroughWalkthroughThis PR updates the Go toolchain version from 1.25.3 to 1.26.0 across 17 example and adapter module files, plus the main module. The CI workflow configuration in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
go.mod (1)
3-3: Consider upgrading to Go 1.26.1.Go 1.26.0 is officially released and stable. However, Go 1.26.1 (the latest patch release) was released on March 6, 2026 and includes bug fixes. Consider updating to
go 1.26.1for stability improvements.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 3, Update the Go toolchain version in the module file by changing the go directive from "1.26.0" to "1.26.1" in go.mod; after updating, run your usual project checks (e.g., go version in CI, go mod tidy and a build/test run) to ensure compatibility with the new patch release..github/workflows/tests.yml (1)
20-20: Standardise Go version selection across all jobs.Line 20 uses
go-version: '1'which resolves to any Go 1.x version and will automatically upgrade to future Go minor releases as they are released. Lines 36 and 62 usego-version-file: 'go.mod'which pins to the version specified ingo.mod. This inconsistency means thecorejob may run on a different Go version than the other jobs, making cross-job test failures harder to reproduce and triage.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tests.yml at line 20, The workflow uses an inconsistent Go selector: change the literal key "go-version: '1'" to use the same pinning mechanism as the other jobs by replacing it with "go-version-file: 'go.mod'" (or otherwise set the exact version that matches go.mod) so the core job uses the same Go version as the other jobs; update the entry containing "go-version: '1'" to "go-version-file: 'go.mod'".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/tests.yml:
- Line 20: The workflow uses an inconsistent Go selector: change the literal key
"go-version: '1'" to use the same pinning mechanism as the other jobs by
replacing it with "go-version-file: 'go.mod'" (or otherwise set the exact
version that matches go.mod) so the core job uses the same Go version as the
other jobs; update the entry containing "go-version: '1'" to "go-version-file:
'go.mod'".
In `@go.mod`:
- Line 3: Update the Go toolchain version in the module file by changing the go
directive from "1.26.0" to "1.26.1" in go.mod; after updating, run your usual
project checks (e.g., go version in CI, go mod tidy and a build/test run) to
ensure compatibility with the new patch release.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f908f505-cf27-43aa-beb6-7c51c9fef429
📒 Files selected for processing (18)
.github/workflows/tests.yml_examples/callback/go.mod_examples/connector/go.mod_examples/gettingstarted/go.mod_examples/orderprocessor/go.mod_examples/schedule/go.mod_examples/sqlexample/go.mod_examples/timeout/go.mod_examples/webui/go.modadapters/jlog/go.modadapters/kafkastreamer/go.modadapters/reflexstreamer/go.modadapters/rinkrolescheduler/go.modadapters/sqlstore/go.modadapters/sqltimeout/go.modadapters/webui/go.modadapters/wredis/go.modgo.mod
1 participant
Simplify the CI test matrix to only test with the latest Go (
'1'), and bump thegodirective ingo.modto1.26.0.Testing multiple Go versions caused flaky failures whenever we bumped deps ahead of the oldest supported version. Since we don't commit to long-term compatibility with older Go releases, there's no value in the matrix.
Summary by CodeRabbit