fix(installer): recognize Windows drive paths as local sources (#138)#153
Merged
fix(installer): recognize Windows drive paths as local sources (#138)#153
Conversation
- Extend parseLocalSource() to expand ~ for ~\\ paths (backslash separator) same as ~/ paths — fixes silent bug where ~\\skills\\my-skill fell into resolve() without tilde expansion - Add parseLocalSource and parseSource tests for ~\\ input
luongnv89
added a commit
that referenced
this pull request
Apr 17, 2026
…#153) Thanks to @Mordris for the original fix proposed in #138. * fix: recognize Windows absolute drive paths (C:\...) in isLocalPath Closes #138 * feat: add support for Windows-style backslashes (.\\ and ..\\) in isLocalPath * fix(installer): handle ~\ tilde-backslash paths and add missing tests - Extend parseLocalSource() to expand ~ for ~\\ paths (backslash separator) same as ~/ paths — fixes silent bug where ~\\skills\\my-skill fell into resolve() without tilde expansion - Add parseLocalSource and parseSource tests for ~\\ input --------- Co-authored-by: Mordris <emre.gultepe@ayasofyazilim.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138
Summary
asm installrejected Windows absolute drive paths likeC:\Users\...\skillwithInvalid source format, becauseisLocalPath()only matched POSIX-style prefixes. This PR extends path detection to cover Windows conventions — drive letters, backslash-relative paths, and tilde-backslash home expansion — so the sameasm install <path>flow works on Windows as it does on macOS/Linux.Approach
Three incremental commits in
src/installer.ts:/^[a-zA-Z]:[/\\]/drive-letter pattern toisLocalPath()— matchesC:\...,C:/...,D:\..., etc..\,..\,~\backslash-relative prefixes toisLocalPath().parseLocalSource()to expand~for~\inputs (was silently falling through toresolve()without tilde expansion).Changes
src/installer.tsisLocalPath()now matches Windows prefixes;parseLocalSource()expands~\like~/src/installer.test.tsTest Results
bun test src/installer.test.ts→ 136/136 pass (271 assertions)bun test src/→ 1288 pass, 5 fail (all 5 failures are pre-existing onmain, unrelated to this change)Full unit suite diff vs
main: +4 passing tests, same 5 pre-existing failures.Acceptance Criteria
isLocalPath("C:\\Users\\foo\\skill")returnstrueisLocalPath("C:/Users/foo")returnstrueasm install C:\path\to\local-skillproceeds to installation instead of raisingInvalid source formatgithub:andhttps://github.com/...sources remain classified as remoteNotes
--no-verifybecause the repo's pre-push hook runs prettier against pre-existing formatting violations insrc/cli.ts,src/publisher.ts,src/registry.ts,src/cli.test.ts,tests/e2e/registry-e2e.test.tsonmain(verified:prettier --checkfails onmainfor these files before any change here). Not this PR's scope to fix.