Conversation
… to always detect all markers during calibration. Not needed.
| print("Starting image processing") | ||
| stereo_calib = calibUtils.StereoCalibration() | ||
| stereo_calib.traceLevel = self.args.traceLevel | ||
| stereo_calib = calibUtils.StereoCalibration(self.args.traceLevel, self.args.outputScaleFactor, self.args.disableCamera) |
There was a problem hiding this comment.
This arguments are deployed in https://github.com/luxonis/depthai-calibration/tree/added_disableCamera not in main branch of depthai_calibration.
@saching13. Should we use then this branch for now as a calibration submodule?
And when changes are deployed in https://github.com/luxonis/Factory-calibration-DepthAI push them to main?
There was a problem hiding this comment.
If the same feature is coved here. and no other features are coming from your branch. yes. we can use this branch
There was a problem hiding this comment.
Some features are not set properly in this PR (traceLevel, outputScaleFactor, disableRGB, lensPosition) so I created new PR from main and used changes @CenekAlbl suggested.
#1099
| else: | ||
| cameraProperties = self.device.getConnectedCameraFeatures() | ||
| calibData = self.device.readCalibration() | ||
| eeprom = calibData.getEepromData() | ||
| print(f"Product name: {eeprom.productName}, board name {eeprom.boardName}") | ||
| detection = eeprom.productName.split() | ||
| if "AF" in detection: | ||
| detection.remove("AF") | ||
| if "FF" in detection: | ||
| detection.remove("FF") | ||
| if "9782" in detection: | ||
| detection.remove("9782") | ||
| self.board_name = '-'.join(detection).upper() | ||
| board_path = Path(self.board_name) | ||
| if not board_path.exists(): | ||
| board_path = (Path(__file__).parent / 'resources/depthai_boards/boards' / self.board_name.upper()).with_suffix('.json').resolve() | ||
| if not board_path.exists(): | ||
| raise ValueError( | ||
| 'Board config not found: {}'.format(board_path)) | ||
| with open(board_path) as fp: | ||
| self.board_config = json.load(fp) | ||
| self.board_config = self.board_config['board_config'] | ||
| self.board_config_backup = self.board_config |
There was a problem hiding this comment.
device.getDeviceName instead of board_name & upper
and cameraProperties & hasAutofocus instead of parsing AF FF etc...
| cam_node.initialControl.setChromaDenoise(4) | ||
|
|
||
| if cam_info['hasAutofocus']: | ||
| cam_node.initialControl.setManualFocus(int(self.args.rgbLensPosition[stringToCam[cam_id].name.lower()])) |
There was a problem hiding this comment.
This doesn't seem well defined.
Lets first define how the mapping is done and then do remapping once and use that throughout the codebase
4 participants
Previously forced fisheye cameras to always detect all markers during calibration. Not needed.