Conversation
…a-module-cms into block-page-property
|
New unit test was added. Updates to guide will be done afterwards... |
nadar
left a comment
There was a problem hiding this comment.
in generel, we have to discuss this change because the interfaces changes, which is a clear BC break, and must be released along with 6.0
I assumed that a minor release can deal with that BC break along with the deprecated annotation. |
no, if someone implement that interface this will break the application
It would be better to first trigger deprecation notices, its better migration path for developers 👍 |
What are you changing/introducing
pageproperty for blocks in both admin and frontend context as a replacement forgetEnvOption('pageObject')resp.getPageObject(), which is now deprecatedtestPageObjectPlaceholderIteration()and thereforeTestingPageObjectBlocktestConcretImplementation()→testConcreteImplementation()ConcretImplementationBlock→ConcreteImplementationBlockWhat is the reason for changing/introducing
QA