Start evicting elements from the DNS memory cache#9583
Open
swankjesse wants to merge 3 commits into
Open
Conversation
swankjesse
commented
Jul 24, 2026
|
|
||
| /** | ||
| * This cache is configured with a target [maxSize], but it will not evict entries until it | ||
| * has twice as many entries. |
Collaborator
Author
There was a problem hiding this comment.
Also considered evicting whenever we were 25% greater than the target. Both 1.25x and 2x have the same big-O runtime. 1.25x is better on memory, 2.x is better on CPU.
yschimke
approved these changes
Jul 24, 2026
| * | ||
| * This evicts in big batches because each eviction must traverse the entire cache. | ||
| */ | ||
| abstract class MemoryCache<K : Any, V : Any>( |
Collaborator
There was a problem hiding this comment.
Can we have a way to mark global changes that would invalidate the whole cache?
Let's say the default network changes, we should not used cached values.
I think for network selection we can have different caches. So it's mainly for global changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.