Remove composer.phar file from the repo#7
Open
ivastly wants to merge 1 commit intom-tymchyk:masterfrom
Open
Conversation
… and should not be there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I guess
composer.pharfile was committed by accident hence I suggest to remove it. Ideally it should be cleaned up from history but maybe only the maintainer can do that?it is almost 2 megabytes, brings zero value (because it is a binary, not source code).
Plus today it caused an issue when I was trying to extend Symfony's Console class and accidentially jumped to the definition of this class inside that .phar file instead of the original vendors 🙂 the .phar has the old version, and it caused some confusion.