Skip to content

Pin django-ninja and add CI setup sanity checks#136

Open
NaitikRishu wants to merge 1 commit intom2b3:mainfrom
NaitikRishu:codex/pin-django-ninja-ci-sanity
Open

Pin django-ninja and add CI setup sanity checks#136
NaitikRishu wants to merge 1 commit intom2b3:mainfrom
NaitikRishu:codex/pin-django-ninja-ci-sanity

Conversation

@NaitikRishu
Copy link

What

Pin django-ninja to 1.4.1 and add setup sanity checks in CI.

Why

Fresh installs can resolve django-ninja to 1.5.x, but current code uses ModelSchema Config style compatible with 1.4.x. This causes manage.py migrate failures in clean environments.

Changes

  • Pin django-ninja in pyproject.toml
  • Add compatibility note in README.md
  • Add setup-sanity job in CI that runs:
    • poetry install
    • poetry run python manage.py check
    • poetry run python manage.py migrate --noinput

Validation

  • Local poetry run python manage.py check passes
  • Local poetry run python manage.py migrate --noinput passes

@NaitikRishu
Copy link
Author

What

Pin django-ninja to 1.4.1 and add setup sanity checks in CI.

Why

Fresh installs can resolve django-ninja to 1.5.x, but current code uses ModelSchema Config style compatible with 1.4.x. This causes manage.py migrate failures in clean environments.

Changes

  • Pin django-ninja in pyproject.toml
  • Add compatibility note in README.md
  • Add setup-sanity job in CI that runs:
    • poetry install
    • poetry run python manage.py check
    • poetry run python manage.py migrate --noinput

Validation

  • Local poetry run python manage.py check passes
  • Local poetry run python manage.py migrate --noinput passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant