Skip to content

implement core replay buffer logic#792

Open
GHOpenonic wants to merge 1 commit into
mainfrom
replay-core
Open

implement core replay buffer logic#792
GHOpenonic wants to merge 1 commit into
mainfrom
replay-core

Conversation

@GHOpenonic

Copy link
Copy Markdown
Collaborator

add replay.py script and test. This does not add replay buffer as a training option, it only implements the core logic. Wiring it into training should be based on the LLC data munging stack #670, #671, #672, #673

@jder

jder commented Jul 20, 2026

Copy link
Copy Markdown
Member

@GHOpenonic can you point me to where this is used in your code? It's a bit hard to understand how these pieces are put together from this alone.

@GHOpenonic

Copy link
Copy Markdown
Collaborator Author

@jder most of it is used/further developed in datasets.py, config.py, base.py, stepper.py, and train.py in replay buffer agent attempt.
replay.py is updated and with implementations in datasets.py and train.py in slow replay buffer
I increase replay's dataloading/handling speed to be roughly gpu-compute bound by changing datasets.py and train.py in improve replay buffer train speed --> gpu bound.
Additionally, if you're curious, I make further changes to all these scripts and replay.py in the Jul 19, 2026 commits in llc_cpu_working, mostly shardtensor implementation phase 3: replay buffer, to get shardtensor to work with replay buffer training

@jder
jder self-requested a review July 21, 2026 13:57
@jder

jder commented Jul 21, 2026

Copy link
Copy Markdown
Member

ok, thanks. I think unless someone needs this sooner (@amogh-gulati maybe?) I vote we stage this after we land the LLC work #670 and rust data loader #800, since building this on top of those probably makes sense.

@amogh-gulati

Copy link
Copy Markdown
Collaborator

ok, thanks. I think unless someone needs this sooner (@amogh-gulati maybe?) I vote we stage this after we land the LLC work #670 and rust data loader #800, since building this on top of those probably makes sense.

I could work on the branch meanwhile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants