Coalesce TorchTrainDataset rollout loads#799
Draft
jder wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TorchTrainDatasetwas materializing each autoregressive rollout step independently.steps + 1prognostic range and preserves the overlapping label/input values.Validation
uv run pytest tests/test_datasets.py -k 'train_dataset_coalesces_shared_prognostic_loads or train_dataset_normalize_pre_fill or train_dataset_no_input_change'uv run pytest tests/test_datasets.py -k 'loader__data_shape__across_schedules or train_dataset_coalesces_shared_prognostic_loads'uvx ruff format --check src/samudra/datasets.py tests/test_datasets.pyuvx ruff check src/samudra/datasets.py tests/test_datasets.pyuvx pre-commit run --files src/samudra/datasets.py tests/test_datasets.pyNote:
uv run pytest tests/test_datasets.pyreached the unrelatedsamudra_multiinference setup and errored becauseflash_perceiveris not installed for auto flash mode in this environment; the training dataset tests before that point passed (117 passed,12 errors).Refs #798