Simplify the canonical data loading boundary#823
Draft
jder wants to merge 2 commits into
Draft
Conversation
oa-jder-bot
force-pushed
the
codex/canonical-reader-llc
branch
from
July 24, 2026 18:18
5c86eff to
e19e931
Compare
This was referenced Jul 24, 2026
oa-jder-bot
force-pushed
the
codex/canonical-reader-llc
branch
from
July 24, 2026 20:10
e19e931 to
0272d29
Compare
oa-jder-bot
changed the base branch from
main
to
fomo/delete-static-data-correctors-816
July 24, 2026 20:11
oa-jder-bot
force-pushed
the
codex/canonical-reader-llc
branch
from
July 24, 2026 20:19
0272d29 to
adac072
Compare
oa-jder-bot
force-pushed
the
codex/canonical-reader-llc
branch
from
July 24, 2026 20:33
adac072 to
2703fcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatasetSpec/CanonicalDataset/OceanDataabstractions withDataLayout,CanonicalSource,BatchPreprocessor,HostBatch, andModelBatchOm4DataSourceConfig.canonicalize_datasetsDataLayoutDataLayoutmainThis intentionally does not add an LLC Rust loader. It establishes the narrower
CanonicalReaderseam that the Rust loader can implement later without exposing xarray or source-specific naming to the training pipeline.Impact
Callers now request ordered canonical channels directly. Canonicalization owns source-specific naming, dimension, mask, and variable-selection rules, while
DataLayoutdescribes only the canonical/model-facing result. This removes repeated variable filtering and normalization wrappers from the hot data-loading path.Validation
uvx pre-commit run --all-filesCUDA_VISIBLE_DEVICES='' uv run pytest -q -m 'not manual and not cuda'