fix: block model from simulating /planner-finish via planner_finish_step#29
Merged
Conversation
Two new guards in validateWorkflowExit: 1. done/await_user_acceptance blocks planner_finish_step unless the target is handle_change_request — the model must tell the user to run /planner-finish; it cannot advance the internal done steps itself. 2. Internal done steps (prepare_output_branch, merge_or_export_result, cleanup_worktree, mark_done, cleanup_plan_files) always block planner_finish_step — /planner-finish drives them atomically. Root cause: user typed /planner-finish as chat text (not as a CLI slash command); model treated it as acceptance and called planner_finish_step six times through internal steps without doing any real work, leaving the plan in done/cleanup_plan_files/running limbo. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…eference New sections: - Mermaid flowchart showing all 8 stages, execution loop, recovery path, and /planner-finish exit — rendered natively on GitHub - Stage/step tables for all 52 steps with descriptions of what each does - "How Local Models Are Kept on Track" — 10 enforcement mechanisms: persisted state, dual-gate tool allowlist, exit-condition validation, echo expected-vs-received, Verification Protocol enforcement, compact checkpoints, AGENTS.md contracts, skill library, Git isolation, recovery Goal: give anyone reading the repo a full mental model of what the extension does and why each piece exists, without reading the source. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.