Optimization and bug fixes#2
Open
Br41nfck wants to merge 7 commits intomacie-k:masterfrom
Open
Conversation
macie-k
requested changes
Apr 15, 2025
Owner
macie-k
left a comment
macie-k
left a comment
There was a problem hiding this comment.
Hey, I appreciate you taking time to contribute!
I will be busy for the next few weeks if not months and won't be able to setup the env to test it. However I took a quick look and here's my initial feedback:
- Please remove the changed README file
- I would prefer the text formatting to be a part of separate PR, this way we can keep the actual changes separated
Thanks again, I will take a closer look once above points are resolved:)
Delete README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BTW: I accidentally broke the CPM counter. How can I fix it?