Mark simulator as a cython package in setup.py#6
Open
bgmeulem wants to merge 3 commits intomackelab:mainfrom
Open
Mark simulator as a cython package in setup.py#6bgmeulem wants to merge 3 commits intomackelab:mainfrom
simulator as a cython package in setup.py#6bgmeulem wants to merge 3 commits intomackelab:mainfrom
Conversation
Author
|
After some digging around, I think I understand some additional issues I'm encountering building the Cython module (apart from what's mentioned above i.e. declaring them in ImportError: numpy.core.multiarray failed to import (auto-generated because you didn't call 'numpy.import_array()' after cimporting numpy; use '<void>numpy._import_array' to disable if you are certain you don't need it)Can be fixed by simply adding the requested line in ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject`Seems like numpy changed the C headers to expect ndarrays of size 80 prior to Solutions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya
This PR proposes to mark
pyloric.simulator.pyxas a Cython extension inseutp.py. This helps out some package managers.I had some issues properly installing this package. I use
pixias a environment manager and front-end to build packages. This did not automatically build the Cython extension. In addition, runningpython setup.py build_extalso does not build it, since it's not marked as an extension insetup. I didn't check whether or not this issue exists when usingpipdirectly, as advertised in the readme. However, I suspect it's good practice anyways to mark Cython packages as such in thesetup.py. I noticed they need the numpy headers to compile the.cfile, hence the additionalinclude_dirsargument insetup