test: add unit tests for JSONFormatter structured log output#486
Draft
madara88645 wants to merge 1 commit into
Draft
test: add unit tests for JSONFormatter structured log output#486madara88645 wants to merge 1 commit into
madara88645 wants to merge 1 commit into
Conversation
Covers JSONFormatter.format() — the production log formatter used by all VibeGraph workers. Tests verify: output is valid JSON, all required fields are present, level/logger/message match the record, request_id is included only when set, exception field appears only when exc_info is provided, and timestamp is a non-empty string. 12 tests across INFO/WARNING/ERROR levels. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 12 unit tests for
JSONFormatter.format()inapp/__init__.py. This is the structured log formatter used by all VibeGraph workers in production, but it had no dedicated tests —test_app.pyonly coveredconfigure_logging().Why it matters:
JSONFormatterconvertsLogRecordobjects to JSON strings that feed into log aggregation pipelines. A regression (missing field, wrong key name, broken JSON) would silently corrupt production observability without raising a type error.What's covered
json.loads()succeedstimestamp,level,logger,message"ERROR""app.routers.upload"propagatedrequest_idincluded when attribute setrequest_idabsent when not setexc_infoset"exception"key with error textexc_info"level": "INFO""level": "WARNING"Files changed
tests/test_json_log_formatter.py(new — 111 lines, no source changes)Test run
Generated by Claude Code