Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Hangfire library dependency and changes the target framework for the Madev.Utils.Infrastructure.Hangfire project. The changes aim to update to a newer version of Hangfire.Core and migrate from .NET 9.0 to .NET 10.0.
Changes:
- Updated Hangfire.Core package from version 1.8.22 to 1.8.23
- Changed target framework from net9.0 to net10.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net9.0</TargetFramework> | ||
| <TargetFramework>net10.0</TargetFramework> |
There was a problem hiding this comment.
This project is being upgraded to net10.0 while other projects in the solution remain on net9.0 (ApplicationInsights.AspNetCore, ApplicationInsights.WorkerService) or net8.0/netstandard2.1 (Http, Mailing packages). This creates an inconsistent target framework strategy across the solution. Consider either upgrading all projects together or document the rationale for having different target frameworks across the solution. Reference: src/Madev.Utils.Infrastructure.ApplicationInsights.AspNetCore/Madev.Utils.Infrastructure.ApplicationInsights.AspNetCore.csproj:4, src/Madev.Utils.Infrastructure.ApplicationInsights.WorkerService/Madev.Utils.Infrastructure.ApplicationInsights.WorkerService.csproj:4
| <TargetFramework>net10.0</TargetFramework> | |
| <TargetFramework>net9.0</TargetFramework> |
|
|
||
| <Authors>Miroslav Adamec</Authors> | ||
| <Company>Madev</Company> | ||
| <Description>Hangfire background job scheduler etilities and extensions</Description> |
There was a problem hiding this comment.
There is a typo in the Description element: "etilities" should be "utilities".
No description provided.