chore: add netstandard support for Hangfire library#8
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds netstandard2.1 support to the Hangfire utility library to enable broader compatibility with .NET Framework and older .NET implementations. The changes include modifying the project to multi-target both netstandard2.1 and net10.0, along with converting from file-scoped to block-scoped namespaces and removing ImplicitUsings to ensure compatibility with netstandard2.1's language features.
Changes:
- Modified project file to target both netstandard2.1 and net10.0, removing ImplicitUsings
- Converted DisableMultipleQueuedItemsFilterAttribute from file-scoped to block-scoped namespace with explicit using statements
- Converted AllowedExecutionTimeRangeAttribute from file-scoped to block-scoped namespace with explicit using statements
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Madev.Utils.Infrastructure.Hangfire.csproj | Added netstandard2.1 multi-targeting and removed ImplicitUsings for compatibility |
| DisableMultipleQueuedItemsFilterAttribute.cs | Converted to block-scoped namespace and added explicit using statements for netstandard2.1 compatibility |
| AllowedExecutionTimeRangeAttribute.cs | Converted to block-scoped namespace and added explicit using statements for netstandard2.1 compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Spelling error: "etilities" should be "utilities".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.