More fixes 1.3.2#1233
Open
Vollstrecker wants to merge 79 commits into
Open
Conversation
|
It replaces: |
Closed
superseedes madler#1226
|
This PR / fork seems to be referred to as the "current tree" in some discussions. IMHO this is highly confusing. Reasonable outsiders would expect only the default branch / IIUC this PR also includes work which was submitted as PRs by other persons. But there is no attribution in these commits, not even a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As more fixes came in, the "pick the last commit" from the fixes-1.3.2 PR wasn't hold-able as it would get really messy over time. Unfortunately you didn't push to develop atm. so I had to include the whole history from there, too.
I noticed that all generation in configure is based on zconf.h.in while cmake relies completely on zconf.h. I remember this was preserved for all the removed MSVC projectfiles. Should we just remove this, so the workaround in zlib.h with the include <zconf.h> you disliked could be removed again.