Conversation
Ids
eb4ea99 to
08ae307
Compare
08ae307 to
5a52c83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option::unwrap_uncheckedis stable since 1.58, and that is IMO much clearer than wrapping things inNonNullbeforehand (see the changelog entry for an example).The real motivation for this change is from #81, where the naive implementation of
Id::retain_autoreleased_nullwould have been completely broken (the extra branch inNonNull::new(ptr).map(|ptr| unsafe { Id::retain_autoreleased(ptr) })would interfere).Also, looking through the code I seem to have used
NonNull::new_uncheckeda lot more than what's entirely correct (+ alloc/+ newcan returnnilwhen out of memory), so changing those tounwrapmakes things better in that regard (albeit a tiny bit slower).