Make autoreleasepool take the pool as a parameter#17
Merged
Conversation
The lifetime of the parameter is the lifetime of references in the pool. This allows us to bound lifetimes on autoreleased objects, thereby making them safe to return.
A nightly-only feature that adds the auto trait `AutoreleaseSafe` and uses it to prevent calling `autoreleasepool` with closures that capture an outer `AutoreleasePool`. This fixes on nightly the unsoundness hole preventing `autoreleasepool` from being used to safely construct references to autoreleased objects.
Prevent using the lifetime from an outer pool when an inner pool is active.
madsmtm
added a commit
that referenced
this pull request
Sep 2, 2021
Make `autoreleasepool` take the pool as a parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool is given as a reference, and the lifetime of the reference is the same as the lifetime of autoreleased objects in the pool. This allows us to bound the lifetimes of autoreleased objects, thereby making them safe to return.
Replaces SSheldon/rust-objc#103. See SSheldon/rust-objc#95 for some more examples and the reasoning behind this.
The primary motivation is to make
NSString::as_strsafe, more info can be found in SSheldon/rust-objc#103 (comment).I did try to explore the concept described in SSheldon/rust-objc#103 (comment) with making
AutoReleaseSafe~Send + Syncon stable, but this proved too much of a usability issue, at least until it's more common to use custom objects (that would then beSend + Sync) rather thanObject.