Improve async type classification and output labels#89
Open
chrismwendt wants to merge 2 commits intomafintosh:masterfrom
Open
Improve async type classification and output labels#89chrismwendt wants to merge 2 commits intomafintosh:masterfrom
chrismwendt wants to merge 2 commits intomafintosh:masterfrom
Conversation
Use the new getCallSites API, which is both a bit simpler to use than V8 one, but also integrates correctly with Node.js source maps support. For a demo, I renamed example.js to example.ts) and used [tsx](https://github.com/privatenumber/tsx) to run it. Before: ``` > npx tsx --enable-source-maps example.ts There are 4 handle(s) keeping the process running. # Timeout example.ts:1 - import whyIsNodeRunning from 'why-is-node-running' // should be your first import example.ts:1 - import whyIsNodeRunning from 'why-is-node-running' // should be your first import # TCPSERVERWRAP example.ts:1 - import whyIsNodeRunning from 'why-is-node-running' // should be your first import example.ts:1 - import whyIsNodeRunning from 'why-is-node-running' // should be your first import # Timeout example.ts:1 - import whyIsNodeRunning from 'why-is-node-running' // should be your first import example.ts:1 - import whyIsNodeRunning from 'why-is-node-running' // should be your first import # TCPSERVERWRAP example.ts:1 - import whyIsNodeRunning from 'why-is-node-running' // should be your first import example.ts:1 - import whyIsNodeRunning from 'why-is-node-running' // should be your first import ``` After: ``` > npx tsx --enable-source-maps example.ts There are 4 handle(s) keeping the process running. # Timeout example.ts:6 - setInterval(() => {}, 1000) example.ts:10 - startServer() # TCPSERVERWRAP example.ts:7 - server.listen(0) example.ts:10 - startServer() # Timeout example.ts:6 - setInterval(() => {}, 1000) example.ts:11 - startServer() # TCPSERVERWRAP example.ts:7 - server.listen(0) example.ts:11 - startServer() ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prints more readable labels for the async resources like "Filesystem request" instead of "FSREQCALLBACK".
Depends on #88
@jonkoops does this look good to you?