refactor(setup-di-compile) port restored Graycore implementation#360
Open
digitalrisedorset wants to merge 1 commit into
Open
refactor(setup-di-compile) port restored Graycore implementation#360digitalrisedorset wants to merge 1 commit into
digitalrisedorset wants to merge 1 commit into
Conversation
Member
|
@digitalrisedorset this needs to be labelled a |
eb059d7 to
521fdec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
setup-di-compilecurrently embeds several workflow orchestration responsibilities directly inside the action:This diverges from the restored Graycore implementation and increases maintenance complexity between forks.
Fixes: N/A
What is the new behavior?
Ports
setup-di-compileto match the restored Graycore implementation more closely.The action is now reduced to a focused compilation step that:
setup:di:compilepathinputRemoved from the action:
actions/checkoutshivammathur/setup-phpphp_versioninputcomposer_versioninputtj-actions/changed-filescache-magentousagecomposer installDoes this PR introduce a breaking change?
Caller workflows must now explicitly:
Example:
Other information
This PR intentionally follows the restored Graycore implementation as closely as possible to reduce divergence between forks and simplify long-term maintenance.