Adding the ability to provide a transform function for transforming data#2
Open
sieverssj wants to merge 6 commits intomageekguy:masterfrom
Open
Adding the ability to provide a transform function for transforming data#2sieverssj wants to merge 6 commits intomageekguy:masterfrom
sieverssj wants to merge 6 commits intomageekguy:masterfrom
Conversation
added 3 commits
November 27, 2013 14:36
…before using it to build columns.
…” to get a handle to the miller object
…tempting to call ‘url’. Also adding the ability to set an initial path for the UI.
Author
|
Closing this pull request. I'm going to open a new one based on the commit IDs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the ability to provide a transform function that will be used on any data that is fetched. This allows an existing REST service's data to work with this plugin without a change to the data returned by the REST service.
I've also made two small tweaks to the scope that is used when calling the 'url' function so that "this" is the plugin scope. This is useful if one needs to get the current path (via this.miller('getPath')) in order to generate an appropriate url. This seems to be congruous with the way toolbar.options and pane.options callbacks are executed.