Skip to content

fix: guard drag overlay to only trigger on external file drags #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tharunika-19 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: guard drag overlay to only trigger on external file drags #1554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50c06be
fix: improve sidebar button visibility and hover effects in both ligh…
tharunika-19 Jun 3, 2026
1fb2194
fix: guard drag overlay to only trigger on external file drags
tharunika-19 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/components/FileUpload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,24 @@ export default function FileUpload({
// Uses a counter so nested dragenter/dragleave don't flicker
useEffect(() => {
const onDragEnter = (e: DragEvent) => {
e.preventDefault();
dragCounterRef.current += 1;
if (dragCounterRef.current === 1) setPageDragging(true);
};
if (!e.dataTransfer?.types?.includes("Files")) return;
e.preventDefault();
dragCounterRef.current += 1;
if (dragCounterRef.current === 1) setPageDragging(true);
};

const onDragLeave = (e: DragEvent) => {
e.preventDefault();
dragCounterRef.current -= 1;
if (dragCounterRef.current === 0) setPageDragging(false);
};

const onDragOver = (e: DragEvent) => {
e.preventDefault(); // required to allow drop
};
if (!e.dataTransfer?.types?.includes("Files")) return;
e.preventDefault();
dragCounterRef.current -= 1;
if (dragCounterRef.current === 0) setPageDragging(false);
};

const onDragOver = (e: DragEvent) => {
if (!e.dataTransfer?.types?.includes("Files")) return;
e.preventDefault();
};
;

const onDrop = (e: DragEvent) => {
e.preventDefault();
Expand Down
10 changes: 5 additions & 5 deletions src/components/PresetSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function RatioBox({
<div
className={cn(
"border-2 flex-shrink-0 rounded-sm transition-colors",
active ? "border-film-600" : "border-[var(--muted)] opacity-60",
active ? "border-film-600" : "border-white/40",
)}
style={{ width: w, height: h }}
/>
Expand Down Expand Up @@ -155,13 +155,13 @@ export default function PresetSelector({ recipe, onChange }: Props) {
"flex flex-col items-center justify-center gap-1 py-2 px-1 rounded-lg border text-center transition-all duration-150 cursor-pointer hover:scale-[1.04] active:scale-[0.97]",
isActive
? "border-film-500 bg-film-50 text-film-600"
: "border-[var(--border)] bg-[var(--surface)] text-[var(--muted)] hover:border-film-300 hover:bg-film-50/30 hover:text-[var(--text)]",
: "border-slate-200 bg-slate-50 text-[var(--text)] dark:border-white/25 dark:bg-white/5 hover:border-film-400 hover:bg-film-50/50 dark:hover:bg-white/10 hover:text-film-600",
)}
>
{icon}
<span className={cn(
"text-[9px] font-heading font-bold uppercase tracking-wide leading-none",
isActive ? "text-film-700" : "text-[var(--muted)]",
isActive ? "text-film-700" : "text-[var(--text)]",
)}>
{label}
</span>
Expand Down Expand Up @@ -204,7 +204,7 @@ export default function PresetSelector({ recipe, onChange }: Props) {
"min-h-[44px] min-w-[44px] flex flex-col items-center justify-center gap-1.5 p-3 rounded-lg border text-center transition-all duration-150 cursor-pointer hover:scale-[1.02] active:scale-[0.98]",
active
? "border-film-500 bg-film-50"
: "border-[var(--border)] bg-[var(--surface)] hover:border-film-300 hover:bg-film-50/30",
: "border-slate-200 bg-slate-50 dark:border-white/25 dark:bg-white/5 hover:border-film-400 hover:bg-film-50/50 dark:hover:bg-white/10 hover:shadow-sm",
)}
>
<RatioBox
Expand Down Expand Up @@ -242,7 +242,7 @@ export default function PresetSelector({ recipe, onChange }: Props) {
"min-h-[44px] min-w-[44px] flex flex-col items-center justify-center gap-1.5 p-3 rounded-lg border text-center transition-all duration-150 cursor-pointer hover:scale-[1.02] active:scale-[0.98]",
recipe.preset === "custom"
? "border-film-500 bg-film-50"
: "border-[var(--border)] bg-[var(--surface)] hover:border-film-300 hover:bg-film-50/30",
: "border-slate-200 bg-slate-50 dark:border-white/25 dark:bg-white/5 hover:border-film-400 hover:bg-film-50/50 dark:hover:bg-white/10 hover:shadow-sm",
)}
>
<Settings2
Expand Down