Skip to content

fix: improve header and footer visual distinction #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adarshofficial560-ux wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −23
Open

fix: improve header and footer visual distinction #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ export default function RootLayout({
<ErrorBoundary>
<header
role="banner"
className="sticky top-0 z-50 flex items-center justify-between border-b border-[var(--border)] bg-[var(--bg)]/95 px-6 py-3 backdrop-blur"
className="sticky top-0 z-50 flex items-center justify-between border-b-2 rounded-b-lg border-[#0070b6] bg-[#f1f5f9] px-6 py-3 backdrop-blur "
>
<div className="flex items-center gap-2">
<BrandLogo size={24} />
<h1 className="text-lg font-semibold">Reframe</h1>
<h1 className="text-lg font-bold dark:text-[#000000]">Reframe</h1>
</div>
<ThemeToggle />
</header>
Expand Down
2 changes: 1 addition & 1 deletion src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function Home() {
target="_blank"
rel="noopener noreferrer"
aria-label="View Reframe on GitHub"
className="hidden sm:flex fixed top-4 right-4 md:right-16 z-50 items-center gap-1.5 px-3 py-1.5 rounded-lg border border-[var(--border)] bg-[var(--surface)] text-[10px] font-heading font-semibold uppercase tracking-wider transition-all duration-200 ease-in-out hover:scale-105 hover:border-[var(--accent)] hover:bg-[var(--accent-muted)] hover:shadow-[var(--shadow)]"
className="hidden sm:flex fixed top-4 right-4 md:right-16 z-50 mr-5 items-center gap-3 px-3 py-1.5 rounded-lg border border-[var(--border)] bg-[var(--surface)] text-[10px] font-heading font-semibold uppercase tracking-wider transition-all duration-200 ease-in-out hover:scale-105 hover:border-[var(--accent)] hover:bg-[var(--accent-muted)] hover:shadow-[var(--shadow)]"
>
⭐ Star on GitHub
</a>
Expand Down
40 changes: 20 additions & 20 deletions src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,20 @@ import {

export default function Footer() {
return (
<footer className="w-full border-t border-[var(--border)] bg-[var(--bg)] text-[var(--text)] px-6 py-16 mt-20 transition-colors duration-300">
<footer className="w-full border-t border-black bg-[#c3c4c7] text-[#030201] px-6 py-16 mt-20 transition-colors duration-300 dark:bg-[#6b7280] dark:text-[#f9fafb]">
<div className="max-w-7xl mx-auto grid grid-cols-1 md:grid-cols-12 gap-y-12 md:gap-x-12">
{/* Brand Section */}
<div className="md:col-span-5 space-y-6">
<div>
<h2 className="text-2xl font-bold tracking-tight">Reframe</h2>
<p className="text-[10px] font-mono tracking-[0.35em] uppercase opacity-50 mt-1">
<h2 className="text-3xl font-extrabold tracking-tight">Reframe</h2>
<p className="text-[10px] font-mono tracking-[0.35em] uppercase mt-1">
Browser Video Studio
</p>
</div>

<p className="text-sm opacity-70 leading-relaxed max-w-md">
<p className="text-sm leading-relaxed max-w-md">
Professional video processing directly in your browser using{" "}
<span className="font-medium opacity-100">FFmpeg.wasm</span> — fast,
<span className="font-medium">FFmpeg.wasm</span> — fast,
private, and open source.
</p>

Expand All @@ -42,7 +42,7 @@ export default function Footer() {
].map((tag) => (
<span
key={tag.label}
className="flex items-center gap-1.5 px-3 py-1 rounded-lg border border-[var(--border)] bg-[var(--surface)] text-[10px] font-semibold tracking-wide uppercase opacity-80 hover:opacity-100 hover:border-[var(--accent)] transition-all"
className="flex items-center gap-1.5 px-3 py-1 rounded-lg border border-[var(--border)] bg-[var(--surface)] text-[10px] font-bold tracking-wide uppercase opacity-100 hover:opacity-80 hover:border-[var(--accent)] transition-all hover:scale-[0.99] "
>
{tag.icon}
{tag.label}
Expand All @@ -53,27 +53,27 @@ export default function Footer() {

{/* Navigation */}
<div className="md:col-span-3 space-y-5">
<h3 className="text-[11px] font-bold uppercase tracking-[0.2em] opacity-60">
<h3 className="text-[11px] font-bold uppercase tracking-[0.2em] ">
Navigation
</h3>

<nav className="flex flex-col gap-3 text-sm">
<nav className="flex flex-col gap-5 text-sm ">
<a
href="https://github.com/magic-peach/reframe"
target="_blank"
rel="noopener noreferrer"
aria-label="GitHub repository"
className="flex items-center gap-2 opacity-70 hover:opacity-100 hover:text-[var(--accent)] transition-all w-fit focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)] rounded"
className="flex items-center gap-2 hover:opacity-100 hover:text-[var(--accent)] transition-all w-fit focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)] rounded"
>
<Github size={14} />
GitHub
<ExternalLink size={10} className="opacity-60" />
<ExternalLink size={10} className="opacity-100" />
</a>

<Link
href="/contact"
aria-label="Contact page"
className="flex items-center gap-2 opacity-70 hover:opacity-100 hover:text-[var(--accent)] transition-all w-fit focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)] rounded"
className="flex items-center gap-2 hover:opacity-100 hover:text-[var(--accent)] transition-all w-fit focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)] rounded"
>
<Mail size={14} />
Contact
Expand All @@ -82,7 +82,7 @@ export default function Footer() {
<Link
href="/privacy"
aria-label="Privacy policy"
className="flex items-center gap-2 opacity-70 hover:opacity-100 hover:text-[var(--accent)] transition-all w-fit focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)] rounded"
className="flex items-center gap-2 hover:opacity-100 hover:text-[var(--accent)] transition-all w-fit focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)] rounded"
>
<Lock size={14} />
Privacy Policy
Expand All @@ -94,12 +94,12 @@ export default function Footer() {
<div className="md:col-span-4 space-y-10 md:justify-self-end w-full md:w-auto">
{/* Newsletter */}
<div className="space-y-3">
<h3 className="text-[11px] font-bold uppercase tracking-[0.2em] opacity-60">
<h3 className="text-[11px] font-bold uppercase tracking-[0.2em] ">
Updates
</h3>

<form
className="flex items-center w-full sm:w-80 bg-[var(--surface)] border border-[var(--border)] rounded-lg px-3 focus-within:border-[var(--accent)] transition"
className="flex items-center w-full sm:w-80 bg-[var(--surface)] border border rounded-lg px-3 focus-within:border-[var(--accent)] transition"
onSubmit={(e) => e.preventDefault()}
aria-label="Newsletter signup"
>
Expand All @@ -108,22 +108,22 @@ export default function Footer() {
required
placeholder="Enter your email"
aria-label="Email address"
className="w-full bg-transparent py-3 text-[11px] font-semibold tracking-widest uppercase placeholder:opacity-30 focus:outline-none"
className="w-full bg-transparent py-3 text-[11px] border border-none font-semibold tracking-widest uppercase placeholder:opacity-100 focus:outline-none focus:ring-0"
/>

<button
type="submit"
aria-label="Subscribe to updates"
onMouseDown={(e) => e.preventDefault()} className="text-[var(--accent)] hover:text-[var(--accent-hover)] transition p-1 focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)] rounded"
onMouseDown={(e) => e.preventDefault()} className="text-[var(--accent)] hover:text-[var(--accent-hover)] transition p-1 focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)] rounded hover:scale-[1.05] hover:color-[#2c3338] active:color-[#1d2327]"
>
<ArrowRight size={16} />
<ArrowRight size={30} strokeWidth={3} color="#c3c4c7" />
</button>
</form>
</div>

{/* Community */}
<div className="space-y-3">
<h3 className="text-[11px] font-bold uppercase tracking-[0.2em] opacity-60">
<h3 className="text-[11px] font-bold uppercase tracking-[0.2em] ">
Community
</h3>

Expand Down Expand Up @@ -158,7 +158,7 @@ export default function Footer() {
aria-label={social.label}
className="relative group p-2.5 rounded-lg border border-[var(--border)] bg-[var(--surface)] hover:border-[var(--accent)] hover:bg-[var(--accent-muted)] transition-all focus-visible:outline focus-visible:outline-2 focus-visible:outline-[var(--accent)]"
>
<span className="opacity-70 group-hover:opacity-100">
<span className="opacity-100 group-hover:opacity-75 transition-opacity transition-duration-100">
{social.icon}
</span>
</a>
Expand All @@ -169,7 +169,7 @@ export default function Footer() {
</div>

{/* Bottom Bar */}
<div className="max-w-7xl mx-auto mt-16 pt-8 border-t border-[var(--border)] flex flex-col md:flex-row justify-between items-center gap-4 text-[10px] font-semibold uppercase tracking-[0.25em] opacity-50">
<div className="max-w-7xl mx-auto mt-16 pt-8 border-t border-[var(--border)] flex flex-col md:flex-row justify-between items-center gap-4 text-[10px] font-bold uppercase tracking-[0.25em] ">
<p>© {new Date().getFullYear()} Reframe · MIT License</p>

<div className="flex items-center gap-2">
Expand Down