docs: document ER macros and recommend the solana-dev companion skill#11
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughDocumentation-only changes recommending a companion ChangesSkill documentation updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jonasXchen
left a comment
There was a problem hiding this comment.
LGTM!
I wonder whether we should also indicate that user can also do it raw without the macro? Since the macro is just injecting conveniently code.
Since its going to be used by agents, its better that not to mention that they can do it raw without the macro since they could skip some of the checks which are included in the macro. I have added non anchor section that shows how they can use it raw without the macro which should cover it. |
Two related skill fixes in the macro/setup guidance:
skill/vrf.mddocumented a stale VRF API (standaloneephemeral-vrf-sdk+create_request_randomness_ix) and was missing#[vrf_callback]— so a copiedcallback has no VRF-identity check and accepts spoofed randomness. Rewritten to match
the
roll-dice/anchorexample:ephemeral-rollups-sdkvrffeature,create_request_scoped_randomness_ix, and both#[vrf]and#[vrf_callback]. Adds aPinocchio section and keeps a note that the old path still works.
skill/SKILL.mdgains a "Commonly-missed macros" block. Notably#[ephemeral]isdocumented as what commit/undelegation needs (it injects
process_undelegation+ theintent builders), not the
delegateinstruction. Adds Pinocchio as a supported path anda "Pair with the
solana-devskill" section.README.mdgains a companion-skill note pointing at Solana Foundation'ssolana-dev(skills have no dependency mechanism, so it's a manual install).
Summary by CodeRabbit