Skip to content

docs: document ER macros and recommend the solana-dev companion skill#11

Merged
dhruvja merged 1 commit into
mainfrom
dhruvja/docs/skill-vrf-macros-and-solana-dev
Jul 9, 2026
Merged

docs: document ER macros and recommend the solana-dev companion skill#11
dhruvja merged 1 commit into
mainfrom
dhruvja/docs/skill-vrf-macros-and-solana-dev

Conversation

@dhruvja

@dhruvja dhruvja commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Two related skill fixes in the macro/setup guidance:

  • skill/vrf.md documented a stale VRF API (standalone ephemeral-vrf-sdk +
    create_request_randomness_ix) and was missing #[vrf_callback] — so a copied
    callback has no VRF-identity check and accepts spoofed randomness. Rewritten to match
    the roll-dice/anchor example: ephemeral-rollups-sdk vrf feature,
    create_request_scoped_randomness_ix, and both #[vrf] and #[vrf_callback]. Adds a
    Pinocchio section and keeps a note that the old path still works.
  • skill/SKILL.md gains a "Commonly-missed macros" block. Notably #[ephemeral] is
    documented as what commit/undelegation needs (it injects process_undelegation + the
    intent builders), not the delegate instruction. Adds Pinocchio as a supported path and
    a "Pair with the solana-dev skill" section.
  • README.md gains a companion-skill note pointing at Solana Foundation's solana-dev
    (skills have no dependency mechanism, so it's a manual install).

Summary by CodeRabbit

  • Documentation
    • Clarified which skill to use for base Solana work versus Ephemeral Rollups-specific tasks.
    • Added stronger guidance on required macros and supported approaches for both Anchor and native programs.
    • Updated VRF examples to reflect the current recommended setup and callback flow.
  • New Features
    • Added documentation for using the main VRF support in the SDK.
    • Included guidance for non-Anchor program support and scoped randomness callbacks.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 528a3726-43cc-46fa-a42c-36a244471aea

📥 Commits

Reviewing files that changed from the base of the PR and between ee4c559 and 210f483.

📒 Files selected for processing (3)
  • README.md
  • skill/SKILL.md
  • skill/vrf.md

Walkthrough

Documentation-only changes recommending a companion solana-dev skill in README.md and skill/SKILL.md, expanding Anchor macro guidance including non-Anchor Pinocchio support, and migrating skill/vrf.md examples from the standalone ephemeral-vrf-sdk crate to the scoped VRF feature within ephemeral-rollups-sdk.

Changes

Skill documentation updates

Layer / File(s) Summary
Companion skill guidance and macro requirements
README.md, skill/SKILL.md
Adds sections recommending installation of the solana-dev companion skill and expands "commonly-missed macros" guidance, including macro ordering and non-Anchor ephemeral-rollups-pinocchio support.
VRF SDK dependency and imports migration
skill/vrf.md
Replaces ephemeral-vrf-sdk dependency and import instructions with guidance to enable the vrf feature on ephemeral-rollups-sdk.
VRF request and callback examples
skill/vrf.md
Updates request randomness and callback examples to use create_request_scoped_randomness_ix, invoke_signed_vrf, and #[vrf]/#[vrf_callback] macro-based account injection/validation.
Macro requirements, oracle queue, and key points reference
skill/vrf.md
Reworks the required-macros explanation, updates oracle queue constant references, adds a Non-Anchor/Pinocchio validation section, and rewrites Key Points bullets.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: sporicle, jonasXchen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main doc updates: ER macro guidance and the solana-dev companion skill recommendation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dhruvja/docs/skill-vrf-macros-and-solana-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dhruvja dhruvja requested a review from jonasXchen July 8, 2026 17:16

@jonasXchen jonasXchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wonder whether we should also indicate that user can also do it raw without the macro? Since the macro is just injecting conveniently code.

@dhruvja

dhruvja commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

LGTM!

I wonder whether we should also indicate that user can also do it raw without the macro? Since the macro is just injecting conveniently code.

Since its going to be used by agents, its better that not to mention that they can do it raw without the macro since they could skip some of the checks which are included in the macro. I have added non anchor section that shows how they can use it raw without the macro which should cover it.

@dhruvja dhruvja merged commit 29ae50f into main Jul 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants