feat(skills/agents): integrate sk harness quality gates across all workflow skills and agents#737
Merged
Merged
Conversation
…#735) - tentacle-orchestration/SKILL.md: add Harness gate row to Phase 3 verification table + note to run sk harness check before Phase 4 when harness.yaml exists - task-step-generator/SKILL.md: extend TEST phase template to include sk harness check when harness.yaml exists - project-onboarding/SKILL.md: add step 0.4 Harness Engineering — sk harness init, verify harness.yaml, sk harness doctor - karpathy-guidelines/SKILL.md: link harness.yaml + sk harness check as the permanent mechanism for verifiable success criteria - workflow-creator/SKILL.md: add HARNESS gate row to gate table example Closes #735 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…copilot-instructions (#736) - All 10 .github/agents/*.agent.md: append Harness Integration section with sk harness check, SK_HARNESS=1, sk harness init, quality-over-speed - .github/copilot-instructions.md: add ## Harness Engineering section after Quality Checklist — 7-principle table with executable commands - AGENTS.md: add Command column to harness principles table with sk harness init, SK_HARNESS=1, sk harness check, sk tentacle etc. Closes #736 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Wires the recently introduced sk harness capability (PR #734) into the workflow skills, agent contracts, and top-level instruction files so quality gates are explicitly named everywhere agents look for guidance. Documentation-only changes; no executable code is modified.
Changes:
- Adds a Harness gate row /
sk harness checkreference totentacle-orchestration,task-step-generator,karpathy-guidelines, andworkflow-creatorskills, and a new step 0.4 (Harness Engineering) plus newtask-step-generatorandworkflow-creatorskill files inproject-onboarding. - Appends an identical
## Harness Integrationsection to all 10.github/agents/*.agent.mdfiles. - Adds a
## Harness Engineeringtable to.github/copilot-instructions.mdand aCommandcolumn to the AGENTS.md harness-principles table.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Adds a Command column to the 7-principle harness table (No-Ship-Bugs row has a missing python3). |
| .github/copilot-instructions.md | New ## Harness Engineering section mirroring AGENTS.md with executable commands. |
| .github/skills/tentacle-orchestration/SKILL.md | Adds Harness row to Phase 3 gate table and sk harness check note before Phase 4. |
| .github/skills/task-step-generator/SKILL.md | New skill; TEST phase template includes sk harness check when harness.yaml exists. |
| .github/skills/task-step-generator/references/step-file-template.md | New annotated step-file template. |
| .github/skills/project-onboarding/SKILL.md | New skill including step 0.4 Harness Engineering. |
| .github/skills/karpathy-guidelines/SKILL.md | New skill linking harness.yaml + sk harness check to verifiable success criteria. |
| .github/skills/workflow-creator/SKILL.md | New skill; example gate table includes a HARNESS row. |
| .github/skills/workflow-creator/references/workflow-template.md | New WORKFLOW.md template. |
| .github/agents/*.agent.md (10 files) | Each appends the same ## Harness Integration section. |
| | 7 | **Knowledge-Recording** | `sk learn` after every bug fix or new pattern. | <!-- AI: call sk learn --mistake or --pattern before task_complete --> | | ||
| | # | Principle | Rule | Command | <!-- AI: enforcement note --> | | ||
| |---|-----------|------|---------|-------------------------------| | ||
| | 1 | **No-Ship-Bugs** | CODE→COMPILE→TEST→VERIFY→COMMIT. Never commit without passing tests. | `python3 test_security.py && test_fixes.py` | <!-- AI: run test_security.py && test_fixes.py before any commit --> | |
Owner
Author
There was a problem hiding this comment.
Fixed in f70c19d — changed python3 test_security.py && test_fixes.py to python3 test_security.py && python3 test_fixes.py in AGENTS.md.
… table Address reviewer comment: 'test_fixes.py' without python3 would try to execute as a shell command and fail. Use explicit 'python3 test_fixes.py'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #735 and #736. Updates all core workflow skills and all agent files to integrate
sk harnessquality gates, enforce quality-over-speed, and ensure consistency across the AI toolchain.Changes
Skills (Issue #735)
Harnessgate row to Phase 3 verification table + note to runsk harness check [--json]before Phase 4 whenharness.yamlexistssk harness checkwhenharness.yamlexistssk harness init, verifyharness.yaml,sk harness doctorharness.yaml+sk harness checkas the permanent mechanism for verifiable success criteriaHARNESSgate row to quality gate table exampleAgents + Instructions (Issue #736)
## Harness Integrationsection withsk harness check,SK_HARNESS=1,sk harness init --yes, quality-over-speed principle## Harness Engineeringsection after Quality Checklist — 7-principle table with executable commandsCommandcolumn to the 🛡️ harness principles tableWhy
The harness skill was created (PR #734) but the rest of the toolchain didn't reference it. Agents could rationalize skipping harness gates even though AGENTS.md has the principles. This PR ensures every skill that drives implementation and every agent contract explicitly names the harness commands.
Verification
git diff --statconfirms surgical additions only