Slightly updated dependencies and ripped out some files#13
Slightly updated dependencies and ripped out some files#13alugocp wants to merge 2 commits intomagicsih:feature/androidx-migrationfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the min SDK version to Android 9 (SDK 28) and removes some example test files to streamline the codebase for the Samsung Galaxy S8 compilation.
- Updated dependency versions and SDK requirements
- Removed ExampleUnitTest.java and ExampleInstrumentedTest.java files
Reviewed Changes
Copilot reviewed 6 out of 22 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/test/java/com/github/magicsih/androidscreencaster/ExampleUnitTest.java | Test file removed; ensure alternative testing coverage is in place. |
| app/src/androidTest/java/com/github/magicsih/androidscreencaster/ExampleInstrumentedTest.java | Test file removed; verify that essential instrumentation tests are maintained if needed. |
Files not reviewed (16)
- .idea/compiler.xml: Language not supported
- .idea/copyright/profiles_settings.xml: Language not supported
- .idea/deploymentTargetDropDown.xml: Language not supported
- .idea/gradle.xml: Language not supported
- .idea/jarRepositories.xml: Language not supported
- .idea/misc.xml: Language not supported
- .idea/modules.xml: Language not supported
- .idea/runConfigurations.xml: Language not supported
- .idea/vcs.xml: Language not supported
- app/build.gradle: Language not supported
- app/proguard-rules.pro: Language not supported
- app/src/main/AndroidManifest.xml: Language not supported
- app/src/main/res/layout/activity_main.xml: Language not supported
- app/src/main/res/values-ko/strings.xml: Language not supported
- gradle.properties: Language not supported
- gradle/wrapper/gradle-wrapper.properties: Language not supported
Comments suppressed due to low confidence (2)
app/src/test/java/com/github/magicsih/androidscreencaster/ExampleUnitTest.java:1
- Removing ExampleUnitTest.java may reduce unit test coverage; please ensure alternative tests exist or consider keeping the file if relevant.
package com.github.magicsih.androidscreencaster;
app/src/androidTest/java/com/github/magicsih/androidscreencaster/ExampleInstrumentedTest.java:1
- Removing ExampleInstrumentedTest.java could lower instrumentation test coverage; please verify that critical device-level testing is still maintained.
package com.github.magicsih.androidscreencaster;
|
Thanks a lot for the PR and the thoughtful note! This project has been inactive for quite a while, so I’ll need to test the changes before making any decisions about merging into For now, I’ll merge your PR into a new branch: Since I currently don’t have an Android dev environment set up, it would be super helpful if you could share any test results, screenshots, or notes on how well it works on your device. That would help me decide if it’s safe to merge into |
I updated the min SDK to 28 (Android 9), plus whatever else I had to do to get this compiling on a Samsung Galaxy S8. No hard feelings if it gets rejected, I see that you targeted an even older SDK and might not want it to lose support.