fix: report the actual message count in the transcript header#158
Open
Rstarks07 wants to merge 1 commit into
Open
fix: report the actual message count in the transcript header#158Rstarks07 wants to merge 1 commit into
Rstarks07 wants to merge 1 commit into
Conversation
The header was built from the requested limit rather than the number of messages actually exported, so exporting a 47-message channel with limit=9999 rendered "This is the latest 9999 messages of the #general channel." self.messages is already populated by export() before build_transcript() runs, and the same value is used a few lines below for MESSAGE_COUNT, so the header now agrees with the count the transcript already reports. raw_export() is unaffected: it passes limit=None, which still renders "start".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The transcript header is built from the requested limit rather than the number of messages actually exported, so it can state something untrue.
Exporting a channel that holds 47 messages with
limit=9999renders:Fix
self.messagesis already populated byexport()beforebuild_transcript()runs, and the very same value is used a few lines below forMESSAGE_COUNT. The header now agrees with the count the transcript already reports.limit = "start" if self.limit: - limit = f"latest {self.limit} messages" + limit = f"latest {len(self.messages)} messages"Notes
raw_export()is unaffected: it passeslimit=None, which still renders"start".python -m unittest discover -s tests -p "test_*.py"passes (30 tests), andruff check --select S,E,F,Iis clean.